Pull in hcat bug fix on Consul connect timeouts #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes fixes the case where CTS would hang indefinitely when running on a machine with DNS issues that cause timeouts while connecting to Consul. Added a log line to provide users context about attempting Consul connection for easier debugging connection issues instead of hanging silently.
|
Looks like i need to update the template helper functions with recent changes to hcat lib. |
|
Updated! hcat helper funcs were friendly to include 🎉 |
sarahethompson
pushed a commit
that referenced
this pull request
Nov 6, 2023
Update TFC driver with SuppressNotification notifier for scheduled tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes fixes the case where CTS would hang indefinitely when
running on a machine with DNS issues that cause timeouts while
connecting to Consul. Added a log line to provide users context
about attempting Consul connection for easier debugging connection
issues instead of hanging silently.
Context: hashicorp/hcat#23