Skip to content

Commit

Permalink
Merge pull request #82 from hashicorp/CC-6659
Browse files Browse the repository at this point in the history
CC-6659: Auto build toolkit on changes
  • Loading branch information
ellacai committed Oct 24, 2023
2 parents 560369b + 0158258 commit f07f73b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@

## Running the test application

- Run `yarn prepare` after any changes to the toolkit to build it to be consumed by the documentation app.
- Run `yarn start:documentation` to start the documentations apps server
- Run `yarn watch:toolkit` - This will automatically re-build the toolkit to be consumed by the documentation app when toolkit file changes are detected via [fb-watchman](https://facebook.github.io/watchman).
- In a separate terminal, run `yarn start:documentation` to start the documentations apps server
- Visit the test application at [http://localhost:4200](http://localhost:4200).

## Adding changelog entries
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.PHONY: build
build:
@yarn prepare
4 changes: 2 additions & 2 deletions documentation/app/templates/components/service-list-item.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@
status.</ComponentApi>

<h3 id="options">Options</h3>
<ComponentApi @name="hideClusterPath" @type="boolean">
Determines whether the cluster ID, partition, and namespace are displayed in the Service List Item. Default value is <CodeInline @code="false" />.
<ComponentApi @name="hideClusterPath" @type="boolean" @default="false">
Determines whether the cluster ID, partition, and namespace are displayed in the Service List Item.
</ComponentApi>

</div>
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"start": "concurrently 'npm:start:*' --restart-after 5000 --prefix-colors cyan,white,yellow",
"start:addon": "yarn workspace @hashicorp/consul-ui-toolkit run start",
"start:documentation": "yarn workspace documentation run start",
"test": "yarn workspaces run test"
"test": "yarn workspaces run test",
"watch:toolkit": "watchman watch-del-all && watchman-make -p '**/toolkit/src/**' -t build"
},
"devDependencies": {
"concurrently": "^7.2.1",
Expand Down

1 comment on commit f07f73b

@vercel
Copy link

@vercel vercel bot commented on f07f73b Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.