-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC-6659: Auto build toolkit on changes #82
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work great. Only thing that isn't working for me is if I create a new component it doesn't seem to work in the docs unless I kill it and re prepare. I am not sure what is the cause. Maybe try looking into it a bit more, but this is still a nice improvement.
- Run `yarn prepare` after any changes to the toolkit to build it to be consumed by the documentation app. | ||
- Run `yarn start:documentation` to start the documentations apps server | ||
- Run `yarn watch:toolkit` - This will automatically detect changes in the toolkit and build it to be consumed by the documentation app. | ||
- In a separate terminal, run `yarn start:documentation` to start the documentations apps server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good idea to mention that this is using fb-watchman
and maybe link to their docs.
β¦p ServiceListItem component API doc
hmm if you create a new component, wouldn't the maybe i'm misunderstanding but I thought that was expected β |
@ellacai Try this flow
I'm pretty sure it will work π€ |
I gave it a try and I think I get the same error? |
π οΈ Description
Now you can do a
yarn watch:toolkit
which will watch for changes intoolkit/src
and automatically rebuild so thedocumentation
app will have the latest changes.Before, you had to run
yarn prepare
after each toolkit change.πΈ Screenshots
video1435768332.mp4
π External Links
jira
ποΈ How to Build and Test the Change
π Definition of Done
π¬ Using the Netlify feedback ladder