Add TCP keepalive settings to proxy config for mesh gateways #14800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyhavlov
requested review from
a team and
boxofrad
and removed request for
a team
boxofrad
approved these changes
Oct 3, 2022
|
I can add the probes parameter - I was debating whether it was useful enough to add to avoid clutter, but it's probably worth it for completeness |
kyhavlov
force-pushed
the
mgw-tcp-keepalives
branch
from
96fca48
to
84f5b70
Compare
kyhavlov
added
backport/1.11
backport/1.12
kyhavlov
force-pushed
the
mgw-tcp-keepalives
branch
from
f6dec87
to
f6a823b
Compare
boxofrad
approved these changes
Oct 14, 2022
kyhavlov
force-pushed
the
mgw-tcp-keepalives
branch
from
f6a823b
to
aaf892a
Compare
This was referenced Oct 15, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TCP keepalive settings to the proxy config to be applied to connections between remote mesh gateways. This makes it easier to handle the case of a proxy in between with its own idle timeout settings (like an AWS NLB, which has a non-configurable 350s idle connection timeout).
TODO: