Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul web-ui services search-bar, when start typing, loses focus on every character input #20109

Closed
dmclf opened this issue Jan 8, 2024 · 3 comments

Comments

@dmclf
Copy link

dmclf commented Jan 8, 2024

Overview of the Issue

Consul web-ui services search-bar, when start typing, loses focus on every character input.
so searching for... for example: hashicorp
(9 characters) would require clicking with mouse back to the search-bar to focus 9 times)

Reproduction Steps

Steps to reproduce this issue:

  1. Go to Consul-UI
  2. Go to services
  3. Type something in the search-bar.
    image
  4. try to type hashicorp in one stretch.
    image
  5. above in my case requires regaining focus after every character input.

Consul info for Server

build:
	prerelease = 
	revision = 9bcafa24
	version = 1.17.1
	version_metadata = 
runtime:
	arch = amd64
	cpu_count = 1
	goroutines = 1227
	max_procs = 1
	os = linux
	version = go1.20.12
runtime:
	arch = arm64
	cpu_count = 2
	goroutines = 498
	max_procs = 2
	os = linux
	version = go1.20.12

Operating system and Environment details

OS: Ubuntu 22.04.3
Architecture: x86_64 + aarch64

dpkg info:

ii  consul         1.17.1-1     amd64        Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.
ii  consul         1.17.1-1     arm64        Consul is a distributed, highly available, and data ce>
absolutelightning added a commit that referenced this issue Jan 8, 2024
@absolutelightning
Copy link
Contributor

absolutelightning commented Jan 8, 2024

Thanks for reporting this @dmclf.
I looked into this. Here's what I have found. In the PR merged by @chris-hut - #19226

A dependency was introduced named - ember-a11y-refocus - because of hashicorp/design-system-components - https://github.com/hashicorp/consul/pull/19226/files#diff-3a968206d6de2fecfc5dacd7d94bab7744c9f5d5c999a816164d95cbc135c316R1871-R1888

In this dependency there is a js code which actually changes the focus to a div with id - ember-a11y-refocus-nav-message

I have opened a PR for your review if this change sounds ok. - #20111

Screenshot 2024-01-08 at 4 00 13 PM

cc @WenInCode @chris-hut

@WenInCode
Copy link
Contributor

Thank you for the report, and thank you @absolutelightning with the proposed fix. I will take some time to go over this afternoon.

Much appreciated!

WenInCode pushed a commit that referenced this issue Jan 9, 2024
* Fixes #20109

* add @hasA11yRefocus false

* add changelog

* Update ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs

Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>

---------

Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>
WenInCode pushed a commit that referenced this issue Jan 9, 2024
* Fixes #20109

* add @hasA11yRefocus false

* add changelog

* Update ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs

Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>

---------

Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>
WenInCode added a commit that referenced this issue Jan 9, 2024
* no-op commit due to failed cherry-picking

* Fixes issue - 20109 (#20111)

* Fixes #20109

* add @hasA11yRefocus false

* add changelog

* Update ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs

Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>

---------

Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>

* fix: stop re-clicking dc dropdown in dc-switch test

* fix: keep nspaces dropdown open in manage nspaces test

---------

Co-authored-by: temp <temp@hashicorp.com>
Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com>
Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>
Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>
@WenInCode
Copy link
Contributor

The fix for this has been merged and will be released as part of the upcoming 1.17 patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants