Fixes issue - 20109 #20111
Merged
Fixes issue - 20109 #20111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tauhid621 for the suggestion to use |
WenInCode
added
the
backport/1.17
|
@absolutelightning This looks great, thank you for submitting this fix. Could you please create a changelog entry for this PR. |
Thanks @WenInCode. Changelog added. |
tauhid621
reviewed
Jan 9, 2024
ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>
tauhid621
approved these changes
Jan 9, 2024
WenInCode
approved these changes
Jan 9, 2024
4 tasks
WenInCode
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Fixes #20109 * add @hasA11yRefocus false * add changelog * Update ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com> --------- Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>
WenInCode
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Fixes #20109 * add @hasA11yRefocus false * add changelog * Update ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com> --------- Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com>
WenInCode
added a commit
that referenced
this pull request
Jan 9, 2024
* no-op commit due to failed cherry-picking * Fixes issue - 20109 (#20111) * Fixes #20109 * add @hasA11yRefocus false * add changelog * Update ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com> --------- Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com> * fix: stop re-clicking dc dropdown in dc-switch test * fix: keep nspaces dropdown open in manage nspaces test --------- Co-authored-by: temp <temp@hashicorp.com> Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com> Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com> Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue - #20109
A dependency was introduced named -
ember-a11y-refocus- because ofhashicorp/design-system-components- https://github.com/hashicorp/consul/pull/19226/files#diff-3a968206d6de2fecfc5dacd7d94bab7744c9f5d5c999a816164d95cbc135c316R1871-R1888In this dependency there is a js code which actually changes the focus to a div with id -
ember-a11y-refocus-nav-messageTesting & Reproduction steps
Manual Testing on local
PR Checklist