Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mechanism to filter out health checks by ID in prepared queries #3727

Closed
slackpad opened this issue Dec 4, 2017 · 0 comments
Closed

Add a mechanism to filter out health checks by ID in prepared queries #3727

slackpad opened this issue Dec 4, 2017 · 0 comments
Assignees
@banks
Labels
type/enhancement Proposed improvement or new feature
Milestone
1.0.7

Comments

@slackpad
Copy link
Contributor

slackpad commented Dec 4, 2017

You could use this to filter out any health check by ID, including the serfHealth check. This wouldn't be a good idea in general, but it might be useful in emergencies. It could also be used to ignore certain kinds of checks that are being evaluated or are broken for some reason, and since prepared queries are managed centrally it's easy to roll these changes out.
@slackpad slackpad added the type/enhancement Proposed improvement or new feature label Dec 4, 2017
@slackpad slackpad added this to the 1.0.2 milestone Dec 4, 2017
@slackpad slackpad modified the milestones: 1.0.2, 1.0.3 Dec 13, 2017
@slackpad slackpad modified the milestones: 1.0.3, Next Jan 13, 2018
@pearkes pearkes modified the milestones: Next, 1.0.7 Apr 3, 2018
@banks banks self-assigned this Apr 9, 2018
@banks banks closed this as completed in 0d8993e Apr 11, 2018
banks added a commit that referenced this issue Apr 11, 2018
@banks
Merge pull request #4022 from hashicorp/pq-filter-checks
6abc465 
Allow ignoring checks by ID when defining a PreparedQuery. Fixes #3727.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banks banks

Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
1.0.7
Development

No branches or pull requests
3 participants
@banks @slackpad @pearkes