Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CA provider config changes result in certificate regeneration across all CA providers #9572

Open
2 of 3 tasks
preetapan opened this issue Jan 15, 2021 · 2 comments
Open
2 of 3 tasks
Labels
theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/reliability

Comments

@preetapan
Copy link
Member

preetapan commented Jan 15, 2021

Currently, changes to two different fields private-key-bits and private-key-type in the CA provider config for Consul connect, don't result in regenerating root certificates.

This results in confusing UX because changes don't take effect after the config is updated , and leads to mismatched expectations particularly when the changes affect the type of encryption used etc.

All providers implement this logic differently, and we will need to create follow up issues per provider to make sure nuances like the intermediate mount point in the Vault CA provider is updated correctly.

  • consul builtin
  • vault
  • AWS PCA
@preetapan preetapan added theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/reliability labels Jan 15, 2021
@rboyer rboyer added the theme/certificates Related to creating, distributing, and rotating certificates in Consul label Mar 26, 2021
rboyer added a commit that referenced this issue Jun 1, 2021
rboyer added a commit that referenced this issue Jun 1, 2021
…/bits for the vault connect CA provider

progress on #9572
rboyer added a commit that referenced this issue Jun 30, 2021
rboyer added a commit that referenced this issue Jun 30, 2021
…/bits for the vault connect CA provider

progress on #9572
rboyer added a commit that referenced this issue Jul 13, 2021
rboyer added a commit that referenced this issue Jul 13, 2021
…/bits for the vault connect CA provider

progress on #9572
rboyer added a commit that referenced this issue Jul 13, 2021
…/bits for the vault connect CA provider (#10331)

progress on #9572
rboyer added a commit that referenced this issue Jul 13, 2021
@tristanmorgan
Copy link
Member

Hi @preetapan , should the changes in private-key-bits always result in the root CA (as opposed to the consul controlled intermediate CA) requiring a reconfiguration?

My example is: I have a Root CA that has EC, 521 bit keys for its certificate while my Intermediate still EC, used 256 bit keys and generates leaf certs with the same EC 256.

With the changes in #10331 I now get the error of cannot update the PrivateKeyBits field without choosing a new PKI mount for the root CA when I try to use the same Root CA mount for Consul Connect.

@dnephin
Copy link
Contributor

dnephin commented Feb 1, 2022

Thank you for reporting this problem! I just wrote up #12246 which I believe may describe the problem you encountered. Given these problems, I think we may need to either change this validation, or remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/reliability
Projects
None yet
Development

No branches or pull requests

5 participants