Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect/ca: require new vault mount points when updating the key type/bits for the vault connect CA provider #10331

Merged
merged 7 commits into from
Jul 13, 2021
Merged

connect/ca: require new vault mount points when updating the key type/bits for the vault connect CA provider #10331

merged 7 commits into from
Jul 13, 2021

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jun 1, 2021 •
edited
Loading

progress on #9572

@rboyer rboyer added theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/consul-vault Relating to Consul & Vault interactions labels Jun 1, 2021
@rboyer rboyer requested a review from a team June 1, 2021 15:46
@rboyer rboyer self-assigned this Jun 1, 2021
@rboyer
Copy link
Member Author

rboyer commented Jun 1, 2021

This is similar in spirit to #10330

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 30, 2021 21:31 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 30, 2021 21:31 Inactive
@rboyer rboyer marked this pull request as ready for review June 30, 2021 21:31
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 30, 2021 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 30, 2021 21:32 Inactive
dnephin
dnephin approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This seems like it fixes the UX problem for the vault provider by refusing the update when it can't be fully applied. The error message should make it clear to the user how to resolve the issue.

agent/consul/connect_ca_endpoint_test.go Outdated Show resolved Hide resolved
agent/consul/connect_ca_endpoint_test.go Outdated Show resolved Hide resolved
agent/consul/connect_ca_endpoint_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul July 13, 2021 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 13, 2021 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 13, 2021 15:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 13, 2021 15:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 13, 2021 15:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 13, 2021 15:28 Inactive
rboyer and others added 7 commits July 13, 2021 10:41
@rboyer
connect/ca: require new vault mount points when updating the key type…
64a7048 
…/bits for the vault connect CA provider

progress on #9572
@rboyer
adding a heavyweight test
96e7125
@rboyer
changelog
db5299e
@rboyer @dnephin
Update agent/consul/connect_ca_endpoint_test.go
e39672b 
Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>
@rboyer @dnephin
Update agent/consul/connect_ca_endpoint_test.go
2b2272b 
Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>
@rboyer @dnephin
Update agent/consul/connect_ca_endpoint_test.go
b3f10b4 
Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>
@rboyer
unused var
5098e7b
@vercel vercel bot temporarily deployed to Preview – consul July 13, 2021 15:47 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 13, 2021 15:47 Inactive
@rboyer rboyer merged commit 7bf9ea5 into main Jul 13, 2021
@rboyer rboyer deleted the ca-keyconfig-vault branch July 13, 2021 16:11
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/408180.

@tristanmorgan tristanmorgan mentioned this pull request Dec 15, 2021
Open
3 tasks
@dnephin dnephin mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees

@rboyer rboyer

Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/consul-vault Relating to Consul & Vault interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rboyer @hc-github-team-consul-core @dnephin