Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Fix flakey tests related to ACL token updates into release/1.15.x #16548

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Backport of Fix flakey tests related to ACL token updates into release/1.15.x #16548

merged 3 commits into from
Mar 6, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16545 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.

Description

The idea is to make sure each test can independently run so this PR reduce the dependency of tests on each other which causes a degree of flakiness.

  • Each tests depended on the same token to run which sometimes meant one test will overwrite changes from the other. So fixing this by allowing each test to create its own individual token that it could update and read to without any interference from other tests.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-1723/fix-flakey-tests/luckily-key-burro branch from 24d9b49 to e9f07f2 Compare March 6, 2023 23:14
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Mar 6, 2023
@roncodingenthusiast roncodingenthusiast added the pr/no-changelog PR does not need a corresponding .changelog entry label Mar 6, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit dd740f0 into release/1.15.x Mar 6, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/NET-1723/fix-flakey-tests/luckily-key-burro branch March 6, 2023 23:36
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@roncodingenthusiast roncodingenthusiast Awaiting requested review from roncodingenthusiast

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/cli Flags and documentation for the CLI interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @roncodingenthusiast