Backport of Avoid decoding nil pointer in map walker into release/1.14.x #17052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17048 to be assessed for backporting due to the inclusion of the label backport/1.14.
The below text is copied from the body of the original PR.
Description
This PR fixes a bug with the mapwalk decoding logic used on the client agents for things like config entries and resolved service configs. Currently, if there is a struct stored within a
map[string]interface{}
with at least one field set and one pointer field unset/nil
(such asEnforcingConsecutive5xx
in thePassiveHealthCheck
struct), the mapwalk logic here would attempt to callreflect.Value.Type()
which is invalid for a nil pointer and we'd getreflect: call of reflect.Value.Type on zero Value
.Testing & Reproduction steps
Replication steps:
reflect: call of reflect.Value.Type on zero Value
PR Checklist
[ ] external facing docs updatedOverview of commits