Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of peering: peering partition failover fixes into release/1.14.x #17377

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #16673 to be assessed for backporting due to the inclusion of the label backport/1.14.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@ndhanushkodi
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


The discovery chain clears out the partition field, but when an upstream is imported into a non-default partition, we need to use that source partition when looking up that upstream. This fixes a couple of cases where that was excluded.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/peering-partition-fixes-main/awfully-sharing-chamois branch 2 times, most recently from dadb281 to 886c2ef Compare May 15, 2023 21:23
@hashicorp-cla
Copy link

hashicorp-cla commented May 15, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


2 out of 3 committers have signed the CLA.

  • ndhanushkodi
  • nathancoleman
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul May 15, 2023 21:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 15, 2023 21:28 Inactive
add local source partition for peered upstreams
@nathancoleman nathancoleman marked this pull request as ready for review May 15, 2023 21:55
@nathancoleman
Copy link
Member

Closing since change was manually backported in #16693

@nathancoleman nathancoleman deleted the backport/peering-partition-fixes-main/awfully-sharing-chamois branch May 15, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants