Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use primary Go version to run Nomad and Vault integration tests #20124

Closed

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Jan 9, 2024

While we defer to other projects w.r.t. how they are built, we should run our tests (and Consul code) using the current latest version we declare.

Follow-up to #20058.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

While we defer to other projects w.r.t. how they are built, we should
run our tests (and Consul code) using the current latest version we
declare.

Follow-up to #20058.
@zalimeni zalimeni added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Jan 9, 2024
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jan 9, 2024
Comment on lines -180 to -183
- uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 # v4.0.1
with:
# Do not explicitly set Go version here, as it should depend on what Vault declares.
go-version-file: 'go.mod'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought these tests were doing the same thing, but after looking more closely, this one installs the compiled binary directly from our releases page, so we only need the "local" Go version for running tests below.

@zalimeni zalimeni closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant