Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up subprocess handling and make shell use optional #3509

Merged
merged 20 commits into from
Oct 4, 2017
Merged

Clean up subprocess handling and make shell use optional #3509

merged 20 commits into from
Oct 4, 2017

Commits on Sep 27, 2017

  1. Clean up handling of subprocesses and make using a shell optional

    @kyhavlov
    kyhavlov committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    4248a34 View commit details
    Browse the repository at this point in the history

  2. Update docs for subprocess changes

    @kyhavlov
    kyhavlov committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    e187c29 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2017

  1. Fix tests for new subprocess behavior

    @kyhavlov
    kyhavlov committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    ac94e07 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2017

  1. More cleanup of subprocesses

    @kyhavlov
    kyhavlov committed Sep 30, 2017
    Configuration menu
    Copy the full SHA
    7489a7e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. Minor adjustments and cleanup for subprocess logic

    @kyhavlov
    kyhavlov committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    4343054 View commit details
    Browse the repository at this point in the history

  2. Makes the watch handler reload test use the new path.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    dba2384 View commit details
    Browse the repository at this point in the history

  3. Adds check tests for new args path, and updates existing tests to use… 

    … new path.
    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    0c9f171 View commit details
    Browse the repository at this point in the history

  4. Adds support for script args in Docker checks.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    adf851d View commit details
    Browse the repository at this point in the history

  5. Fixes the sanitize unit test.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    08c23ea View commit details
    Browse the repository at this point in the history

  6. Adds panic for unknown watch type, and reverts back to Run().

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    f7f0b64 View commit details
    Browse the repository at this point in the history

  7. Adds shell option back to consul lock command.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    0bc10d1 View commit details
    Browse the repository at this point in the history

  8. Adds shell option back to consul exec command.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    262cb43 View commit details
    Browse the repository at this point in the history

  9. Adds shell back into consul watch command.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    d6f33f9 View commit details
    Browse the repository at this point in the history

  10. Refactors signal forwarding and makes Windows-friendly.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    af34efc View commit details
    Browse the repository at this point in the history

  11. Adds a clarifying comment.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    12c2d71 View commit details
    Browse the repository at this point in the history

  12. Changes error wording to a warning.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    9373824 View commit details
    Browse the repository at this point in the history

  13. Scopes signals to interrupt and kill. 

    This avoids us trying to send SIGCHILD to the dead process.
    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    f343900 View commit details
    Browse the repository at this point in the history

  14. Adds an error for shell=false for consul exec.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    c0bf614 View commit details
    Browse the repository at this point in the history

  15. Adds notes about the deprecated script and handler fields.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    073ccc0 View commit details
    Browse the repository at this point in the history

  16. De-nests an if statement.

    @slackpad
    slackpad committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    1051b46 View commit details
    Browse the repository at this point in the history