UI: Bugfix. Move to a different TextEncoder/Decoder #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The previously used TextEncoder/Decoder (used as a polyfill for browsers that don't have a native version) didn't expose an encoder via CommonJS. Use a different polyfill that exposes both a decoder and an encoder. 2. The feature detection itself was flawed. This does a less error prone detection that ensures native encoding/decoding where available and polyfilled encoding/decoding where not available.
pearkes
approved these changes
Sep 12, 2018
ui-v2/app/utils/atob.js
Outdated
| @@ -1,8 +1,8 @@ | |||
| import TextEncoderLite from 'npm:text-encoder-lite'; | |||
| import TextEncoding from 'npm:text-encoding'; | |||
| import base64js from 'npm:base64-js'; | |||
| export default function(str, encoding = 'utf-8') { | |||
| // str = String(str).trim(); | |||
There was a problem hiding this comment.
Should this be cleaned up?
There was a problem hiding this comment.
Doh! Yup, done, cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browsers that don't have a native version) didn't expose an encoder via
CommonJS. Use a different polyfill that exposes both a decoder and an
encoder.
detection that ensures native encoding/decoding where available and polyfilled
encoding/decoding where not available.
Fixes #4570