UI: Move the text encoding polyfill to a a proper detecting polyfill #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
reviewed
Oct 8, 2018
| @@ -65,6 +65,8 @@ module.exports = function(defaults) { | |||
| // modules that you would like to import into your application | |||
| // please specify an object with the list of modules as keys | |||
| // along with the exports of each module as its value. | |||
| app.import('node_modules/text-encoding/lib/encoding-indexes.js', {outputFile: 'assets/encoding-indexes.js'}) | |||
There was a problem hiding this comment.
I don't think I've run across outputFile in ember-cli docs - that's really handy. 👌
There was a problem hiding this comment.
I vaguely remember reading about them in a GH issue, that was an issue saying they were missing from the documentation 😄
There was a problem hiding this comment.
Extra note I figured on this yesterday, might be helpful if you ever need to use this. If you do this multiple times to the same outputFile it concats the sources together into the same file:
app.import('source-1', {outputFile: 'all.js'})
app.import('source-2', {outputFile: 'all.js'})
At some point 🔜 I'll probably merge the 2 files above into the same file to save a request.
meirish
approved these changes
Oct 8, 2018
|
👍 when I saw the bump my face was literally like that emoji 😮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted a huge bump in the size of my built output from a few weeks ago:
I followed it back to #4613 which was to add a different TextEncoder polyfill, but this wasn't exactly polyfilled. Even though certain browsers didn't need the polyfill, the polyfill was still in the bundled vendor.js file.
This PR splits this out into a proper polyfill. The TextEncoder polyfill is now only requested/downloaded if the browser you are using a browser that doesn't have a native implementation (basically IE).
Overall this puts my vendor.js file back to the size it was previously.