Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3217: upgrade leads to protocol version (2) is incompatible: [1, 0] #5313

Merged

Conversation

pierresouchay
Copy link
Contributor

This is fixed in hashicorp/memberlist#178, bump
memberlist to fix possible split brain in Consul.

…ible: [1, 0]

This is fixed in hashicorp/memberlist#178, bump
memberlist to fix possible split brain in Consul.
@pierresouchay
Copy link
Contributor Author

@mkeeler here is the PR for memberlist bug fix integration, as requested in
#3217 (comment)

@mkeeler mkeeler requested review from a team February 4, 2019 21:54
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkeeler
Copy link
Member

mkeeler commented Feb 4, 2019

I noticed that the memberlist repo has no CI setup so I am trying to get some memberlist tests to pass before merging this one.

I see it now.

@mkeeler
Copy link
Member

mkeeler commented Feb 5, 2019

For anyone seeing this for memberlist tests you can run GO111MODULE=on make test

@mkeeler mkeeler merged commit bfcfcc0 into hashicorp:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants