Agent Auto Config: Implement Certificate Generation #8360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
from
f980196
to
72d7439
Compare
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
2 times, most recently
from
8804cc6
to
0c285dd
Compare
mkeeler
force-pushed
the
refactor/ca-roots-and-cert-gen
branch
2 times, most recently
from
0cff079
to
da9d453
Compare
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
from
0c285dd
to
fc2def9
Compare
mkeeler
force-pushed
the
refactor/ca-roots-and-cert-gen
branch
from
da9d453
to
2855e31
Compare
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
2 times, most recently
from
c4d6c6c
to
48ebfb6
Compare
mkeeler
force-pushed
the
refactor/ca-roots-and-cert-gen
branch
from
2855e31
to
6c654ac
Compare
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
from
48ebfb6
to
51cfb7a
Compare
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
4 times, most recently
from
dd1ab55
to
76d26a7
Compare
crhino
reviewed
Jul 24, 2020
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
from
76d26a7
to
5606190
Compare
mkeeler
commented
Jul 24, 2020
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
2 times, most recently
from
d714351
to
7b1d59a
Compare
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
from
7b1d59a
to
c6eb1d6
Compare
|
@i0rek We could try and merged the auto encrypt and auto config code however it would still need to support the two different RPC endpoints and each endpoint has different type of authorization. There is probably a way to do it well but I think its outside the scope of this PR for now. |
crhino
reviewed
Jul 27, 2020
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
from
c6eb1d6
to
db2e760
Compare
Most of the groundwork was layed in previous PRs between adding the cert-monitor package to extracting the logic of signing certificates out of the connect_ca_endpoint.go code and into a method on the server. This also refactors the auto-config package a bit to split things out into multiple files. # Conflicts: # agent/agent.go
mkeeler
force-pushed
the
feature/auto-config/cert-generation
branch
from
03b71e3
to
400d0d1
Compare
|
🍒✅ Cherry pick of commit 34034b7 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jul 28, 2020
Most of the groundwork was laid in previous PRs between adding the cert-monitor package to extracting the logic of signing certificates out of the connect_ca_endpoint.go code and into a method on the server. This also refactors the auto-config package a bit to split things out into multiple files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on
auto_encryptfor generating and managing the agent's certificate including renewals.This PR includes a couple distinct things.
AutoConfig.InitialConfigurationRPC endpoint to sign a CSR and push down the certificate, roots and any manually managed CA certs known to that server.CertMonitorappropriately with the results. This also changes how we persist the RPC response and restore it when restarting the agent. Instead of just persisting theConfigalready translated and ready to be used as a config source we encode the entire response with the json protobuf marshaller. Then when restoring we pull out the config and translate it to the appropriate structure capable of being used as a config source. The restoration process then can reinject the certificates/keys in the RPC response back into theCertMonitor&tlsutil.Configurator.TODO: