Skip to content

Commit

Permalink
Merge pull request #2030 from hashicorp/ts/fix-default-export-types
Browse files Browse the repository at this point in the history
Stop reexporting type files
  • Loading branch information
WenInCode committed Apr 22, 2024
2 parents 834faba + e3221b5 commit 868c1d5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changeset/slow-scissors-flow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": patch
---

Fixed default export warnings by preventing `types.js` files from being reexported
6 changes: 0 additions & 6 deletions packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@
"./components/hds/alert/description.js": "./dist/_app_/components/hds/alert/description.js",
"./components/hds/alert/index.js": "./dist/_app_/components/hds/alert/index.js",
"./components/hds/alert/title.js": "./dist/_app_/components/hds/alert/title.js",
"./components/hds/alert/types.js": "./dist/_app_/components/hds/alert/types.js",
"./components/hds/app-footer/copyright.js": "./dist/_app_/components/hds/app-footer/copyright.js",
"./components/hds/app-footer/index.js": "./dist/_app_/components/hds/app-footer/index.js",
"./components/hds/app-footer/item.js": "./dist/_app_/components/hds/app-footer/item.js",
Expand All @@ -133,7 +132,6 @@
"./components/hds/button-set/index.js": "./dist/_app_/components/hds/button-set/index.js",
"./components/hds/button/index.js": "./dist/_app_/components/hds/button/index.js",
"./components/hds/card/container.js": "./dist/_app_/components/hds/card/container.js",
"./components/hds/card/types.js": "./dist/_app_/components/hds/card/types.js",
"./components/hds/code-block/copy-button.js": "./dist/_app_/components/hds/code-block/copy-button.js",
"./components/hds/code-block/description.js": "./dist/_app_/components/hds/code-block/description.js",
"./components/hds/code-block/index.js": "./dist/_app_/components/hds/code-block/index.js",
Expand Down Expand Up @@ -198,10 +196,8 @@
"./components/hds/icon-tile/index.js": "./dist/_app_/components/hds/icon-tile/index.js",
"./components/hds/icon-tile/types.js": "./dist/_app_/components/hds/icon-tile/types.js",
"./components/hds/interactive/index.js": "./dist/_app_/components/hds/interactive/index.js",
"./components/hds/interactive/types.js": "./dist/_app_/components/hds/interactive/types.js",
"./components/hds/link/inline.js": "./dist/_app_/components/hds/link/inline.js",
"./components/hds/link/standalone.js": "./dist/_app_/components/hds/link/standalone.js",
"./components/hds/link/types.js": "./dist/_app_/components/hds/link/types.js",
"./components/hds/menu-primitive/index.js": "./dist/_app_/components/hds/menu-primitive/index.js",
"./components/hds/modal/body.js": "./dist/_app_/components/hds/modal/body.js",
"./components/hds/modal/footer.js": "./dist/_app_/components/hds/modal/footer.js",
Expand Down Expand Up @@ -255,12 +251,10 @@
"./components/hds/text/code.js": "./dist/_app_/components/hds/text/code.js",
"./components/hds/text/display.js": "./dist/_app_/components/hds/text/display.js",
"./components/hds/text/index.js": "./dist/_app_/components/hds/text/index.js",
"./components/hds/text/types.js": "./dist/_app_/components/hds/text/types.js",
"./components/hds/toast/index.js": "./dist/_app_/components/hds/toast/index.js",
"./components/hds/toast/types.js": "./dist/_app_/components/hds/toast/types.js",
"./components/hds/tooltip-button/index.js": "./dist/_app_/components/hds/tooltip-button/index.js",
"./components/hds/yield/index.js": "./dist/_app_/components/hds/yield/index.js",
"./components/hds/yield/types.js": "./dist/_app_/components/hds/yield/types.js",
"./helpers/hds-link-to-models.js": "./dist/_app_/helpers/hds-link-to-models.js",
"./helpers/hds-link-to-query.js": "./dist/_app_/helpers/hds-link-to-query.js",
"./modifiers/hds-clipboard.js": "./dist/_app_/modifiers/hds-clipboard.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/components/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const plugins = [
// "app" tree. Things in here should also be in publicEntrypoints above, but
// not everything in publicEntrypoints necessarily needs to go here.
addon.appReexports([
'components/**/*.js',
'components/**/!(*types).js',
'helpers/**/*.js',
'modifiers/**/*.js',
]),
Expand Down Expand Up @@ -86,4 +86,4 @@ export default {
output: addon.output(),
plugins: plugins,
external: ['ember-modifier', 'prismjs'],
};
};

0 comments on commit 868c1d5

Please sign in to comment.