Stop reexporting type files #2030
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -27,7 +27,7 @@ const plugins = [ | |||
| // "app" tree. Things in here should also be in publicEntrypoints above, but | |||
| // not everything in publicEntrypoints necessarily needs to go here. | |||
| addon.appReexports([ | |||
| 'components/**/*.js', | |||
| 'components/**/!(*types).js', | |||
There was a problem hiding this comment.
if we are following this pattern for type location going forward, should I also update the helper and modifiers pattern below?
There was a problem hiding this comment.
Currently the hds modifiers and helpers live under the same folder(s). which folder structure are you envisioning?
Types next to the files:
packages/components/src/helpers/hds-link-to-models.ts
packages/components/src/helpers/hds-link-to-models.types.ts
packages/components/src/modifiers/hds-clipboard.ts
packages/components/src/modifiers/hds-clipboard.types.ts
Creation of parent folders (is it possible? does it work in Ember?):
packages/components/src/helpers/hds-link-to-models/index.ts
packages/components/src/helpers/hds-link-to-models/types.ts
packages/components/src/modifiers/hds-clipboard/index.ts
packages/components/src/modifiers/hds-clipboard/types.ts
There was a problem hiding this comment.
That is a very good question. I'm not sure what the answer is atm, and so maybe it's best not to address this now.
I'll try out the above options just to see what it looks like/what works. It would be nice if it could be consistent across all components/modifiers/helpers/etc.
There was a problem hiding this comment.
I'm not super familiar with app reexports - if the types are removed does this mean that a consumer in a v1 addon can't import things from type files (like enums etc), or is that still possible since they are included in the public entrypoints above?
There was a problem hiding this comment.
Ya I believe that is handled by the publicEntrypoints. CUT currently re-exports the types (whoops!) but we also have an index file that imports and exports all the types. That file is not part of the appReexports but it is accessible from cloud-ui.
There was a problem hiding this comment.
appReexports is a compatability layer tat only needed for v1 apps with hbs/js, with current setup it would still export types
There was a problem hiding this comment.
We currently don't have type files for helpers and modifiers, so I wouldn't worry about it just now.
| @@ -27,7 +27,7 @@ const plugins = [ | |||
| // "app" tree. Things in here should also be in publicEntrypoints above, but | |||
| // not everything in publicEntrypoints necessarily needs to go here. | |||
| addon.appReexports([ | |||
| 'components/**/*.js', | |||
| 'components/**/!(*types).js', | |||
There was a problem hiding this comment.
We currently don't have type files for helpers and modifiers, so I wouldn't worry about it just now.
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
|
@alex-ju thanks for the suggestion and review |
Feel free to merge whenever time allows |
📌 Summary
Updates the rollup glob pattern to exlude
types.jsfiles within thecomponentsfolder.🛠️ Detailed description
It seems like rollup adds all the ts/js files within the components/ folder into the ember-addon/app-js bit in the package.json and expects there to a
defaultexport. I think this is because it expects all those files to be components as is the ember convention? This results in noisey errors for our consumers.I thought we could just add the types pattern under the
{ exclude: string[] }options in theappReexportsbut it did not work as I would have expected, or perhaps my glob was not right. So I ended up updating thepatternsglobs to exclude types.📸 Screenshots
Before:
After:
🔗 External links
appReexports
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.