move ember-deep-tracked dep to showcase #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alex-ju
approved these changes
Feb 14, 2024
alex-ju
reviewed
Feb 14, 2024
Dhaulagiri
force-pushed
the
br-deep-tracking-value
branch
from
440ccbd
to
3f6295e
Compare
|
Also hard to spot in the diff – thanks for catching that! |
Merged
|
Indeed, I obviously didn't notice it when I had reviewed it 👀 . Just something I stumbled across poking around in the codebase this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
AFAICT that is only used in the showcase but was moved to a component dep in a7206c8