feat(ember-flight-icons): update blueprint #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
50521c2
to
d4f149f
Compare
2 tasks
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
d4f149f
to
fda4e3f
Compare
didoo
reviewed
Jun 5, 2024
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
2 times, most recently
from
484f775
to
0c2f6b5
Compare
didoo
reviewed
Jun 5, 2024
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
0c2f6b5
to
a26d1a7
Compare
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
2 times, most recently
from
ffc27f7
to
5f7dc0f
Compare
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
5f7dc0f
to
4eb5765
Compare
|
With an eye toward some consistency across the monorepo I excised most of the blueprint-related changes here and got those in #2166. We should be able to rebase this one to get it down to just the TS-related changes and more cleanly review and release that. |
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
4eb5765
to
be8fd7e
Compare
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
be8fd7e
to
a7a46ff
Compare
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
a7a46ff
to
c268fb2
Compare
didoo
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
I think is OK, but please wait an approval from @alex-ju or @Dhaulagiri before merging
2 tasks
alex-ju
approved these changes
Jun 18, 2024
|
You must have Developer access to commit code to HashiCorp on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
Ensures type safety without the need for inline type assertions
aklkv
force-pushed
the
feat/embe-flight-icons-bluprint-update
branch
from
6d4fa88
to
8cde778
Compare
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Preparatory PR for #2170
(context: https://hashicorp.slack.com/archives/C06NMSYDZPA/p1717440951790419?thread_ts=1717099148.439879&cid=C06NMSYDZPA)
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.