feat(ember-flight-icons): convert to typescript & publish types #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aklkv
changed the base branch from
main
to
feat/embe-flight-icons-bluprint-update
aklkv
force-pushed
the
feat/modernize-ember-flight-icon
branch
from
f343a26
to
808a7a3
Compare
|
You must have Developer access to commit code to HashiCorp on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
aklkv
force-pushed
the
feat/modernize-ember-flight-icon
branch
from
808a7a3
to
e016af7
Compare
aklkv
force-pushed
the
feat/modernize-ember-flight-icon
branch
from
e016af7
to
a306543
Compare
didoo
reviewed
Jun 17, 2024
There was a problem hiding this comment.
I see this change also in https://github.com/hashicorp/design-system/pull/2142/files#diff-e31a2dfa439cd2cc8aa9b1e01d10b79db320fd27009fdb3b129ea1bae67aa866 so this means that this branch should be rebased on #2142 no?
aklkv
force-pushed
the
feat/modernize-ember-flight-icon
branch
from
a306543
to
35aa878
Compare
Ensures type safety without the need for inline type assertions
alex-ju
force-pushed
the
feat/modernize-ember-flight-icon
branch
from
35aa878
to
abd1462
Compare
alex-ju
approved these changes
Jun 18, 2024
aklkv
merged commit 6d4fa88
into
feat/embe-flight-icons-bluprint-update
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
The main goal of this change is to make sure types are created and published for the Ember Flight Icon component
🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3315
Previously created PR that was massed up: #2126
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.