Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu: use gpg -o instead of tee for getting gpg key #1737

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Mar 14, 2023

Second attempt at #797

This time using gpg -o as suggested by @phinze

Attaching a screenshot of what happens when users follow the instructiosn as-is. Your terminal turns into an unusable mess. It's an awful UX.

Screenshot from 2023-03-14 11-19-27

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 4:37PM (UTC)

@github-actions
Copy link

Some suggested prefixes and emojis that may help to write clear, actionable code review comments:

Praise 🙌 Question 🙋 Thought 💭 Blocker 🚧 Future 📌 Optional 🎨 Nitpick ⛏️
Expand for comment prefix descriptions
Prefix+Emoji Description
Praise 🙌 Use to highlight something positive. It's nice to try to leave one per review, but don't leave false praise just to leave one of these comments.
Question 🙋 Use to gain clarity from the code author. The conversation could evolve into any one of these other categories. Only the reviewer should resolve these comment threads.
Thought 💭 Use to share context, leave a breadcrumb, or share an idea that came up while reviewing.
Blocker 🚧 Use to request changes that block merging the current PR. Only the reviewer should resolve these comment threads.
Future 📌 Use to request changes that the code author can choose to address in the current PR or a follow-up one.
Optional 🎨 Use to suggest optional changes that you feel strongly about but ultimately defer to the code author to make a decision on. These can be comments that turn into valuable conversation starters for adopting new code styles, guidelines, or team practices.
Nitpick ⛏️ Use to suggest changes based on loose opinions or personal preferences. The difference between this and Optional 🎨  is how strong the code reviewer's opinion is.

@github-actions
Copy link

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@shoenig shoenig marked this pull request as ready for review March 14, 2023 16:36
@shoenig shoenig requested a review from a team as a code owner March 14, 2023 16:36
@ashleemboyer
Copy link
Contributor

Hey @shoenig! 😊 These will affect the /${productSlug}/downloads pages (e.g. /waypoint/downloads, /vault/downloads), and not the page shown in your screenshot. I think the page in your screenshot is a Nomad tutorial, and that content would not be affected by your changes here. Are you sure these cross-product changes are what you're looking for?

@phinze
Copy link

phinze commented Mar 14, 2023

Hello! I can confirm that the usage of tee dumps binary output onto the terminal in every place it is used, so this would be a UX improvement everywhere.

Here's an example of a recent Vagrant bug report from a user who hit this.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This PR is stale because it has been open 20 days with no activity. It will be closed in 5 days unless you remove the stale label or comment.

@github-actions github-actions bot added the stale label Apr 4, 2023
@shoenig shoenig added this pull request to the merge queue Apr 4, 2023
Merged via the queue into main with commit 2e871aa Apr 4, 2023
@shoenig shoenig deleted the use-gpg-o-option branch April 4, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants