Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu: pipe to dd when downloading gpg key #797

Closed
wants to merge 1 commit into from

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Aug 8, 2022

This PR swaps the use of tee for dd when creating the gpg key file
for setting up the apt repository on Debian/Ubuntu systems.

Using tee causes binary output to be displayed on the terminal, which
is not desireable (see hashicorp/nomad#14047)

This PR swaps the use of 'tee' for 'dd' when creating the gpg key file
for setting up the apt repository on Debian/Ubuntu systems.

Using 'tee' causes binary output to be displayed on the terminal, which
is not desireable (see  hashicorp/nomad#14047)
@vercel
Copy link

vercel bot commented Aug 8, 2022

@shoenig is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dev-portal ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 1:56PM (UTC)

Copy link

@phinze phinze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this make it onto the site, but I also have one tweak to suggest!

@@ -31,7 +31,7 @@ export const generateDefaultPackageManagers = (
{
label: 'Ubuntu/Debian',
commands: [
`wget -O- https://apt.releases.hashicorp.com/gpg | gpg --dearmor | sudo tee /usr/share/keyrings/hashicorp-archive-keyring.gpg`,
`wget -O- https://apt.releases.hashicorp.com/gpg | gpg --dearmor | sudo dd of=/usr/share/keyrings/hashicorp-archive-keyring.gpg`,
Copy link

@phinze phinze Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`wget -O- https://apt.releases.hashicorp.com/gpg | gpg --dearmor | sudo dd of=/usr/share/keyrings/hashicorp-archive-keyring.gpg`,
`wget -O- https://apt.releases.hashicorp.com/gpg | sudo gpg --dearmor -o /usr/share/keyrings/hashicorp-archive-keyring.gpg`,

Hello! I came here also chasing gobbledygook in the install output for Vagrant. I have an alternate fix to suggest though via the Docker install instructions for linux. gpg supports a -o flag so we can just use that directly instead.

@kendallstrautman
Copy link
Contributor

👋🏻 Hello! checking back to see if we still want to get these updates in? If not, let's close this PR out ☺️

@github-actions
Copy link

This PR is stale because it has been open 20 days with no activity. It will be closed in 5 days unless you remove the stale label or comment.

@github-actions github-actions bot added the stale label Feb 24, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This PR was closed because it has been marked stale for 5 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants