Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/homebrew: use hashicorp/tap/terraform for terraform #87

Merged
merged 1 commit into from
Apr 4, 2023
Merged

tools/homebrew: use hashicorp/tap/terraform for terraform #87

merged 1 commit into from
Apr 4, 2023

Conversation

ryancragun
Copy link
Collaborator

  • Move the homebrew template into a different file and embed it into the binary
  • Retab the homebrew template to use spaces instead of tabs as it's Ruby
  • Update the terraform dep to use hashicorp/tap/terraform

@ryancragun
tools/homebrew: use hashicorp/tap/terraform for terraform
eb5d911 
* Move the homebrew template into a different file and embed it into the
  binary
* Retab the homebrew template to use spaces instead of tabs as it's Ruby
* Update the terraform dep to use hashicorp/tap/terraform

Signed-off-by: Ryan Cragun <me@ryan.ec>
@ryancragun ryancragun added the changelog/none Will be excluded from release notes. label Apr 4, 2023
@ryancragun ryancragun requested a review from a team as a code owner April 4, 2023 20:42
@ryancragun
Copy link
Collaborator Author

I created a PR to update the existing formula here https://github.com/hashicorp/homebrew-internal/pull/39

rebwill
rebwill approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@rebwill rebwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Out of curiosity, what's your reason for embedding this in the binary?

@ryancragun
Copy link
Collaborator Author

Oh, I just think it's easier to maintain as a separate file. Most editors will auto-tab to tab in a Go file, but since it's Ruby we want to expand spaces.

@ryancragun ryancragun merged commit c1f597a into main Apr 4, 2023
@ryancragun ryancragun deleted the homebrew branch April 4, 2023 20:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebwill rebwill rebwill approved these changes

Assignees
No one assigned
Labels
changelog/none Will be excluded from release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryancragun @rebwill