Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

Secrets #20

Closed
nicholasjackson opened this issue Jan 13, 2018 · 6 comments
Closed

Secrets #20

nicholasjackson opened this issue Jan 13, 2018 · 6 comments
Assignees
Projects
Milestone

Comments

@nicholasjackson
Copy link
Contributor

Provide capability to store and access secrets for a function using HashiCorp Vault.

This issue is currently blocked by the lack of E2E TLS in OpenFaaS, there is currently an open issue to resolve this.

@nicholasjackson nicholasjackson self-assigned this Jan 13, 2018
@nicholasjackson nicholasjackson added this to ToDo in Version 0.3 Jan 16, 2018
@nicholasjackson nicholasjackson added this to the Version 0.4 milestone Jan 16, 2018
@nicholasjackson nicholasjackson added this to To Do in Version 0.4 Jan 16, 2018
@nicholasjackson nicholasjackson removed this from ToDo in Version 0.3 Jan 16, 2018
@cpitkin
Copy link
Contributor

cpitkin commented Feb 25, 2018

@nicholasjackson Any way we can get this added in the near future. I have a couple really good use cases but I need secrets via Vault. I would totally help write the code to get my Go skills up to par. I definitely need the practice.

@nicholasjackson
Copy link
Contributor Author

@cpitkin Yes, I have actually been having a think about this, I think the best way is that the secrets are directly added to vault and the nomad provider would just read the secrets from Vault rather than the CLI pushing secrets to to the provider and it writing and reading Vault. This both should give a more consistent Vault / Nomad workflow.

I will get this added to my schedule and hopefully will complete it this week.

@alexellis
Copy link
Contributor

The CLI only specifies the name of secrets... not the plaintext values.

@nicholasjackson
Copy link
Contributor Author

I have added a first pass at this in the following pull request
#48

Currently this would only support the v1 API, templates have a different form for the v2 api, we could detect this based on the path as v1 would use /secret/mysecret and v2 /secret/data/mysecret

@acornies
Copy link
Collaborator

I've also added #50 to provide a consistent approach to faas-cli usage and yaml declaration of secrets (only secret names, no Vault-style paths since I don't think that translates between providers).
In a future version I can definitely see us supporting v2 and more advanced usage of Vault.

@nicholasjackson
Copy link
Contributor Author

All merged in v0.3.1

Version 0.4 automation moved this from To Do to Done Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Version 0.4
  
Done
Development

No branches or pull requests

4 participants