This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Iterating on secret implementation: #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated vaultkey prefix to follow this convention: secret/openfaas/{function}
- updated deploy test to reflect changes
- Added mapped volumes to the secrets location to follow openfaas format
- secrets in a function.yml are now defined the same way as k8s, Swarm
Signed-off-by: Andrew Cornies <acornies@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nicholasjackson, I wanted to iterate on the work you started for secrets, so here it is:
Example Vault secret curl:
Example faas-cli:
The secrets are then present in the container:
sudo docker exec -it cows-{uuid} ls /var/openfaas/secrets another_secret cows_testThis makes it so that secrets are defined the same way in .yml or faas-cli regardless if openfaas is running on K8s, Swarm or Nomad. However, it is expected that the secrets be stored in this format in Vault: secret/openfaas/{function}.