This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Add /system/info endpoint for faas-nomad #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this change is to make faas-nomad compatible with the latest version of the API Gateway in OpenFaaS. Each provider should be able to advertise the underlying provider and the version of the code. A new version of faas-provider (0.6) is vendored into the repo which brings in an optional health endpoint (turned off by default). The version is being passed to the provider from main.go. A subsequent change should implement the health endpoint. A unit test was added for the info endpoint using the format found for the other endpoints. The advertised information in /system/info will be consumed by the API gateway and logged for help debugging issues. It can also be used to turn on/off UI features such as the "network" field which does not make sense for all providers. Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
|
(^ That is likely unrelated to the PR.) |
|
Bump |
|
Sorry will check this tomorrow |
|
Awesome, thank you Nic! |
|
Hey @alexellis I had to merge your changes on top of my replication branch I have created a new pull request with your changes. Would you give this a quick eyeball and I will get this merged into master, the provider is now compatible with version 0.8.1 of the gateway with this pull request. Kind regards, Nic |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to make faas-nomad compatible with the
latest version of the API Gateway in OpenFaaS. Each provider should
be able to advertise the underlying provider and the version of the
code. A new version of faas-provider (0.6) is vendored into the repo
which brings in an optional health endpoint (turned off by default).
The version is being passed to the provider from main.go.
A subsequent change should implement the health endpoint.
A unit test was added for the info endpoint using the format found
for the other endpoints.
The advertised information in /system/info will be consumed by the
API gateway and logged for help debugging issues. It can also be
used to turn on/off UI features such as the "network" field which
does not make sense for all providers.
Signed-off-by: Alex Ellis (VMware) alexellis2@gmail.com
Other comments
Nic this was tested via unit tests which I think prove the behavior works as expected, but not through bringing up a nomad environment. Please could you give it a run-through before or after merging?