-
Notifications
You must be signed in to change notification settings - Fork 46
Feature/annotations labels and health check #45
Feature/annotations labels and health check #45
Conversation
Glad to see this shaping up. Just a quick one - are you using prune with Your first commit is also not signed-off. This is Nic's repo, but you might want to format your commit messages in some more detail - https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md#commit-messages Some examples: openfaas/faas-netes@622203c |
Signed-off-by: should generally be a name too like "Alex Ellis" |
Thanks for the pointers. I'm relatively new to Golang dev in general so any help is appreciated. I'll amend those commits. |
I'm just using |
Yes - see how prune is used in the OpenFaaS repos for faas-netes for example in Gopkg.toml then rm -rf vendor and run dep ensure again. You may have to reset the commits to prevent them recording all the files coming and then being removed again. |
Feel free to ask on OF Slack if you need help with git. |
- Updated and prune dependencies - Implemented annotations and labels for Nomad API - Added /healthz support - Updated reader test Signed-off-by: acornies <acornies@gmail.com>
de103ad
to
28f7afc
Compare
Rebased commits and fixed up commit message with sign-off. |
Removing accidental saltstack additions from another feature branch Signed-off-by: acornies <acornies@gmail.com>
Looks good to me, only comment would be to add the annotations stuff to the docs but I will merge and add that. Nice work @acornies |
This PR addresses #40 as well as implements the /healthz check