This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Feature/upstream secrets endpoint #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated vagrant provisioning process - added vault approle commands - added vault info types - WIP token/login on startup - Secret handler stub created Signed-off-by: Andrew Cornies <acornies@gmail.com>
- CLUD implemented in secrets handler - Refactored Vault property of provider config - fixed up Vagrantfile overrides - TODO: secret handler tests Signed-off-by: Andrew Cornies <acornies@gmail.com>
- Support both POST,PUT faas-cli commands - Change secrets convention to work with upstream secrets API - Error formatting Signed-off-by: Andrew Cornies <acornies@gmail.com>
- Light refactor of Vault calls into VaultService - Added much needed token renewal for Vault AppRole tokens - Updating provision policy to 5m - TODO unit tests for VaultService and secrets handler Signed-off-by: Andrew Cornies <acornies@gmail.com>
|
|
- removed provider config dependency - changed signatures of of the CLUD methods Signed-off-by: Andrew Cornies <acornies@gmail.com>
- Forgot to delete duplicate method - reduced number of returns in getSecrets Signed-off-by: Andrew Cornies <acornies@gmail.com>
|
I think this looks pretty decent. Have you thought about doing some validation on secret names? I think we left the out of the other providers so if you do this it would be great to get a PR to them too |
|
Hey @acornies Getting a couple of test failures on CI, I am guessing this is a go mod issue, it seems to work fine when I run the tests locally. Could you check this out pls? |
- update faas-provider mod - update faas mod - update mapstructure - update vault mod Signed-off-by: Andrew Cornies <acornies@gmail.com>
Fix to vault prefix instead of policy name Signed-off-by: Andrew Cornies <acornies@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #69 by implementing the /system/secrets (upstream) gateway API using Vault secrets v1.
Includes: