This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Switch consul resolver to use ServiceAddress #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Cornies <acornies@gmail.com>
Signed-off-by: Andrew Cornies <acornies@gmail.com>
|
Hi, can you maybe shed some light around this change? what's the benefit? |
|
Hi @orefalo This change facilitates faas-nomad on single-node instance w/ multiple interfaces (docker0 +) etc. I suspect this will be the same address as before in most use cases. |
|
Hi @acornies, that's what I understood from the link I provided, but glad you clarified. I also found you other repos; especially this one - https://github.com/acornies/faas-nomad-demos. battling vagrant (actually more vbox) on catalina at this point |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Cornies acornies@gmail.com