Add a uint indexer #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a uint indexer that works for any uint type: uint, uint8, uint16, uint32, uint64.
slackpad
approved these changes
Apr 11, 2017
index.go
Outdated
| } | ||
|
|
||
| val := v.Uint() | ||
| buf := make([]byte, 8) |
There was a problem hiding this comment.
You think it's worth exploiting a memory footprint advantage by having IsUintType() return the required size and allocating just what's needed?
There was a problem hiding this comment.
Probably not worth the complexity...
There was a problem hiding this comment.
It was easy enough! Done!
|
linking #30 related to this PR |
thaJeztah
added a commit
to thaJeztah/swarmkit
that referenced
this pull request
Sep 25, 2019
full diff: hashicorp/go-memdb@cb9a474...v1.0.3 possibly relevant changes: - hashicorp/go-memdb#21 Added a new MultiIndexer for map[string]string fields - hashicorp/go-memdb#23 Adds support for fine-grained watches - hashicorp/go-memdb#25 Delays mutation notifications until after the whole transaction is applied - fixes hashicorp/go-memdb#24 Notify channels close early during a commit - hashicorp/go-memdb#26 Add a uint indexer - hashicorp/go-memdb#31 Fix buffer size when encoding uint fields - hashicorp/go-memdb#35 Add DeletePrefix method that allows faster deletes of objects in the id index - hashicorp/go-memdb#37 Add WatchCtx function - hashicorp/go-memdb#38 WatchCtx returns error - hashicorp/go-memdb#39 Add a FilterIterator that wraps a ResultIterator - hashicorp/go-memdb#42 use ErrNotFound for deleting missing item - hashicorp/go-memdb#50 fix: dereference pointers for String Fields - hashicorp/go-memdb#52 fix: allow nil string pointers - hashicorp/go-memdb#59 Add Int indexing - hashicorp/go-memdb#60 Add CompoundMultiIndexer - hashicorp/go-memdb#81 Add LowerBound to allow for index range scans Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/swarmkit
that referenced
this pull request
Sep 25, 2019
full diff: hashicorp/go-memdb@cb9a474...v1.0.3 possibly relevant changes: - hashicorp/go-memdb#21 Added a new MultiIndexer for map[string]string fields - hashicorp/go-memdb#23 Adds support for fine-grained watches - hashicorp/go-memdb#25 Delays mutation notifications until after the whole transaction is applied - fixes hashicorp/go-memdb#24 Notify channels close early during a commit - hashicorp/go-memdb#26 Add a uint indexer - hashicorp/go-memdb#31 Fix buffer size when encoding uint fields - hashicorp/go-memdb#35 Add DeletePrefix method that allows faster deletes of objects in the id index - hashicorp/go-memdb#37 Add WatchCtx function - hashicorp/go-memdb#38 WatchCtx returns error - hashicorp/go-memdb#39 Add a FilterIterator that wraps a ResultIterator - hashicorp/go-memdb#42 use ErrNotFound for deleting missing item - hashicorp/go-memdb#50 fix: dereference pointers for String Fields - hashicorp/go-memdb#52 fix: allow nil string pointers - hashicorp/go-memdb#59 Add Int indexing - hashicorp/go-memdb#60 Add CompoundMultiIndexer - hashicorp/go-memdb#61 Add LowerBound to allow for index range scans Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
banks
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Using a fork of go-immutable-radix temporarily until PR #26 is accepted * Adding Snapshot method to Txn to create a read-only snapshot of the transaction * Removed temporary replacement; updated go-immutable-radix to v1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a uint indexer that works for any uint type: uint,
uint8, uint16, uint32, uint64.