Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txn snapshot #66

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Txn snapshot #66

merged 4 commits into from
Apr 6, 2020

Conversation

feldgendler
Copy link
Contributor

This PR introduces a Snapshot method to Txn.

The new method allows to take a read-only snapshot of an open transaction.
The snapshot will survive the commit or abort of the transaction.

Depends on the feature introduced to go-immutable-radix by hashicorp/go-immutable-radix#26. This PR adds a temporary replace directive to go.mod which will become unnecessary once that PR is merged.

@feldgendler
Copy link
Contributor Author

Now that hashicorp/go-immutable-radix#26 is merged, can you please merge this one, too?

@feldgendler
Copy link
Contributor Author

@banks, can you please review this?

Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @feldgendler. This LGTM!

@banks banks merged commit fd620dd into hashicorp:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants