Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix T.Fatalf has arg got of wrong type #88

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fix T.Fatalf has arg got of wrong type #88

merged 1 commit into from
Apr 23, 2019

Conversation

eclipseo
Copy link
Contributor 

+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
# github.com/armon/go-metrics
./start_test.go:56: T.Fatalf format %s has arg got of wrong type float32
./start_test.go:85: T.Fatalf format %s has arg got of wrong type float32
./start_test.go:127: T.Fatalf format %s has arg got of wrong type float32
FAIL	github.com/armon/go-metrics [build failed]

blalor
blalor suggested changes Nov 14, 2018
View reviewed changes
Copy link

@blalor blalor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in error; disregard

@blalor
Copy link

blalor commented Dec 11, 2018

@ryanuber @kyhavlov Can you please take a look at this PR?

This was referenced Dec 11, 2018
Closed
Open
@hugoluchessi
Copy link

hugoluchessi commented Mar 6, 2019 •
edited

Also closes #72.

Wont this be merged?

@cgbaker cgbaker merged commit 78b1d70 into hashicorp:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blalor blalor blalor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eclipseo @blalor @hugoluchessi @cgbaker