Change create/update options in resources to match JSON:API Type field #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently a lot of the Create/UpdateOptions structs for various resources have an
ID
attribute that represents the primary field in JSON:API. This is misleading, as JSON:API indicates that this field is aType
field.This PR is to make the fields more accurately represent the JSON:API spec. It also removes the frequent
options.ID = ""
as that is not necessary.Testing plan
No changes. Run all the tests locally.
Output from tests
External links