Fix linting errors #414
Merged
Fix linting errors #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
reviewed
May 27, 2022
annawinkler
force-pushed
the
aw/linting
branch
3 times, most recently
from
4a5ffa3
to
31057b7
Compare
annawinkler
commented
Jun 3, 2022
| for { | ||
| defer tick.Stop() | ||
|
|
||
| for { //nolint |
There was a problem hiding this comment.
We discussed the two approaches for this block. The linter would have us simplify this block to iterate over the range of the ticker values, but we prefer to stick with the for / select option because it's consistent with how we use tickers in this library.
brandonc
approved these changes
Jun 3, 2022
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issues seen when running
golangci-lint runTesting plan
golangci-lint runon this branch, you should not see any issues.Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.