Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store and allow retrieval of the string of the version in its original form #16

Closed
matthew-andrews opened this issue Jun 18, 2016 · 0 comments · Fixed by docker/cli#2159
Closed

Store and allow retrieval of the string of the version in its original form #16

matthew-andrews opened this issue Jun 18, 2016 · 0 comments · Fixed by docker/cli#2159
Assignees
@mitchellh

Comments

@matthew-andrews
Copy link

matthew-andrews commented Jun 18, 2016 •
edited
Loading

For my use case (a little API that grabs a GitHub repository's tags and then matches semver patterns against it) it would be helpful if there were a way back to the string of the version in its original form.

https://api.mattandre.ws/semver/github/hashicorp/terraform/<v0.5

$ curl https://api.mattandre.ws/semver/github/hashicorp/terraform/%3Cv0.5
v0.4.2

With one small tweak, this is very easy to achieve with your go-version library, see here:-
matthew-andrews@401ade5

Could this (or something like it) be something you could consider merging into the proper library?
@febbraro febbraro mentioned this issue Mar 8, 2017
Closed
mitchellh added a commit that referenced this issue Jul 15, 2018
@mitchellh
Support Original to return original version
2acf8f8 
Fixes #16, #27

This keeps track of the original version that was parsed and makes it
available as `v.Original`. Additionally, I updated the String docs to
note that the returned value is canonicalized according to some set of
rules.
@mitchellh mitchellh mentioned this issue Jul 15, 2018
Merged
@mitchellh mitchellh self-assigned this Jul 15, 2018
knqyf263 pushed a commit to knqyf263/go-version that referenced this issue Apr 14, 2019
@mitchellh @knqyf263
Support Original to return original version
cb33b22 
Fixes hashicorp#16, hashicorp#27

This keeps track of the original version that was parsed and makes it
available as `v.Original`. Additionally, I updated the String docs to
note that the returned value is canonicalized according to some set of
rules.
thaJeztah added a commit to thaJeztah/cli that referenced this issue Oct 24, 2019
@thaJeztah
bump hashicorp/go-version v1.2.0
87cf5b6 
full diff: hashicorp/go-version@23480c0...v1.2.0

includes:

- hashicorp/go-version#53 Implement GreaterThanOrEqual + LessThanOrEqual
- hashicorp/go-version#45 Add new constructor that strictly adheres to semver specs
- hashicorp/go-version#40 Support Original to return original version
    - fixes hashicorp/go-version#16 Store and allow retrieval of the string of the version in its original form
    - fixes hashicorp/go-version#27 Support for zero padded numbers (e.g. `17.03.0-ce`)
- hashicorp/go-version#41 Segments64 makes a copy to match Segments
- hashicorp/go-version#38 When using a specific pattern, unintended results are returned

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this issue Oct 24, 2019
Merged
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this issue Oct 29, 2019
@thaJeztah
bump hashicorp/go-version v1.2.0
58b5bab 
full diff: hashicorp/go-version@23480c0...v1.2.0

includes:

- hashicorp/go-version#53 Implement GreaterThanOrEqual + LessThanOrEqual
- hashicorp/go-version#45 Add new constructor that strictly adheres to semver specs
- hashicorp/go-version#40 Support Original to return original version
    - fixes hashicorp/go-version#16 Store and allow retrieval of the string of the version in its original form
    - fixes hashicorp/go-version#27 Support for zero padded numbers (e.g. `17.03.0-ce`)
- hashicorp/go-version#41 Segments64 makes a copy to match Segments
- hashicorp/go-version#38 When using a specific pattern, unintended results are returned

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 87cf5b606a07607b03b311085d5b66a0944ec53c
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchellh mitchellh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump hashicorp/go-version v1.2.0 thaJeztah/cli
2 participants
@mitchellh @matthew-andrews