Add new constructor that strictly adheres to semver specs #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Yeah I think this is a good way to do it.
I think some internal details might have to change (i.e. moving from just switching the regexp to actually a boolean-like flag that signifies we're in "semver mode"), but those are unexported details so we can easily change that up later.
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Oct 24, 2019
full diff: hashicorp/go-version@23480c0...v1.2.0 includes: - hashicorp/go-version#53 Implement GreaterThanOrEqual + LessThanOrEqual - hashicorp/go-version#45 Add new constructor that strictly adheres to semver specs - hashicorp/go-version#40 Support Original to return original version - fixes hashicorp/go-version#16 Store and allow retrieval of the string of the version in its original form - fixes hashicorp/go-version#27 Support for zero padded numbers (e.g. `17.03.0-ce`) - hashicorp/go-version#41 Segments64 makes a copy to match Segments - hashicorp/go-version#38 When using a specific pattern, unintended results are returned Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Oct 29, 2019
full diff: hashicorp/go-version@23480c0...v1.2.0 includes: - hashicorp/go-version#53 Implement GreaterThanOrEqual + LessThanOrEqual - hashicorp/go-version#45 Add new constructor that strictly adheres to semver specs - hashicorp/go-version#40 Support Original to return original version - fixes hashicorp/go-version#16 Store and allow retrieval of the string of the version in its original form - fixes hashicorp/go-version#27 Support for zero padded numbers (e.g. `17.03.0-ce`) - hashicorp/go-version#41 Segments64 makes a copy to match Segments - hashicorp/go-version#38 When using a specific pattern, unintended results are returned Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 87cf5b606a07607b03b311085d5b66a0944ec53c Component: cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes below adds a new optional constructor that strictly adheres to semver pre-release specs
-separatorWithout the hyphen
-separator between the version and pre-release, it adds complexity to parse for X.Y.Z as non-negative integers -- where the Z component encompasses the pre-release and becomes alphanumeric