Use local ref. targets for each.* references
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-foreach-refs
branch
from
6fa640f
to
d386af9
Compare
radeksimko
force-pushed
the
f-foreach-refs
branch
from
d386af9
to
cb106f5
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes collection of reference targets, such that we now collect
each.keyandeach.valueas targets to thefor_eachattribute. This in turn enables go-to-definition and go-to-references betweenfor_eachand the two references.Additionally, it updates completion, hover and semantic tokens, to make use of these reference targets and just treat them like any other valid reference.
UX in Terraform
Completion (same as before)
Hover (same as before)
Go-to-* (new)