decoder/schema: Add support for Keyword as Constraint
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-expr-cons-keyword
branch
5 times, most recently
from
92dddb0
to
fa9a71f
Compare
radeksimko
force-pushed
the
f-expr-cons-keyword
branch
from
fa9a71f
to
02cb964
Compare
radeksimko
force-pushed
the
f-expr-cons-keyword
branch
from
02cb964
to
44c82a7
Compare
radeksimko
force-pushed
the
f-expr-cons-keyword
branch
from
44c82a7
to
1aaa58b
Compare
dbanck
approved these changes
Jan 26, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-ls#496
hashicorp/terraform-schema@442c5c8 is downstream reflection of this constraint. The examples below leverage that commit. It also however makes it clear that
Keywordoften in schema relies onOneOfconstraint, so for full support of keywords, that constraint has to be implemented.UX Impact
Since keywords aren't nested, this is expected to be no-op for the end-user and essentially just work the same as before.
Completion
Hover
Semantic Tokens