Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder: Add support for AnyExpression as Constraint #232

Merged
merged 37 commits into from
Apr 6, 2023
Merged

decoder: Add support for AnyExpression as Constraint #232

merged 37 commits into from
Apr 6, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Mar 15, 2023 •
edited
Loading

UX

We provide completion of references, function and literals for all expressions

2023-04-06 12 03 54

Completion, hover and semantic tokens also work for nested expressions, like within objects or function calls.
2023-04-06 14 50 08

@dbanck dbanck added the enhancement New feature or request label Mar 15, 2023
@dbanck dbanck force-pushed the f-expr-any branch 3 times, most recently from f482476 to 5a1c34d Compare March 17, 2023 11:48
@radeksimko radeksimko self-assigned this Mar 17, 2023
@radeksimko radeksimko force-pushed the f-expr-any branch 3 times, most recently from b7a73a0 to c5bba37 Compare April 3, 2023 20:27
This was referenced Apr 4, 2023
Merged
Merged
Merged
@radeksimko radeksimko force-pushed the f-expr-any branch 2 times, most recently from c4e8b11 to 174221d Compare April 4, 2023 12:29
@dbanck dbanck marked this pull request as ready for review April 5, 2023 15:10
@dbanck dbanck requested a review from a team as a code owner April 5, 2023 15:10
radeksimko and others added 15 commits April 6, 2023 10:30
@radeksimko @dbanck
decoder: Report function names with appropriate token type
9c744a1
@radeksimko @dbanck
decoder: Account for traversal trailing dot in functionExpr argument
2e12db4
@radeksimko @dbanck
decoder: Fix reporting of semantic tokens for functionExpr
73a54e1
@dbanck
decoder: Test semantic tokens for functions
9f763e5
@dbanck
decoder: Extend hover tests for functions
e7a6667
@radeksimko @dbanck
decoder: Remove TODOs (follow-up issues will be filed)
b80119d
@radeksimko @dbanck
decoder: add test for mismatching argument in semtok (Any)
c82e3fa
@radeksimko @dbanck
decoder: add test for mismatching argument in hover (Any)
5feeaa6
@radeksimko @dbanck
decoder: Add remaining tests for Any
250321c
@radeksimko @dbanck
decoder: Add literal type hover tests for Any
352c5e1
@dbanck
decoder: Add reference hover tests for Any
fbb9361
@dbanck
decoder: Add semantic token tests for Any
1266df0
@dbanck
decoder: Return early for function calls without references
6f40469
@dbanck
decoder: Test collection for reference targets for Any
4dd2044
@dbanck
decoder: Test collection for reference origins for Any
84d0789
@dbanck dbanck mentioned this pull request Apr 6, 2023
Merged
@radeksimko radeksimko removed their assignment Apr 6, 2023
radeksimko
radeksimko approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbanck dbanck merged commit c5ed325 into main Apr 6, 2023
@dbanck dbanck deleted the f-expr-any branch April 6, 2023 16:13
@radeksimko radeksimko mentioned this pull request Apr 14, 2023
Open
This was referenced Apr 24, 2023
Closed
Closed
Open
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbanck @radeksimko