Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder: Add support for AnyExpression as Constraint #232

Merged
merged 37 commits into from
Apr 6, 2023
Merged

decoder: Add support for AnyExpression as Constraint #232

merged 37 commits into from
Apr 6, 2023

Commits on Apr 6, 2023

  1. lang: Add new FunctionCandidateKind

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    69814df View commit details
    Browse the repository at this point in the history

  2. decoder: Implement completion for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    443b6bb View commit details
    Browse the repository at this point in the history

  3. decoder: Implement hover for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    8a69f38 View commit details
    Browse the repository at this point in the history

  4. decoder: Implement semantic tokens for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    a2863b9 View commit details
    Browse the repository at this point in the history

  5. decoder: Implement reference origins for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    8ce9322 View commit details
    Browse the repository at this point in the history

  6. decoder: Implement reference targets for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    a2ddf05 View commit details
    Browse the repository at this point in the history

  7. decoder: Test completion for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    15c2651 View commit details
    Browse the repository at this point in the history

  8. decoder: Test hover for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    35b12df View commit details
    Browse the repository at this point in the history

  9. decoder: Implement functionExpr (completion+hover+semtok+origins+targ… 

    …ets)
    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3254aaf View commit details
    Browse the repository at this point in the history

  10. reference: Refactor TraversalToLocalOrigin to accomodate AnyExpression

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    24300d4 View commit details
    Browse the repository at this point in the history

  11. decoder: Implement completion for AnyExpression

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    090284b View commit details
    Browse the repository at this point in the history

  12. decoder: Implement hover for AnyExpression

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    721fa94 View commit details
    Browse the repository at this point in the history

  13. decoder: Implement semantic tokens for AnyExpression

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e00d6f8 View commit details
    Browse the repository at this point in the history

  14. decoder: Implement reference origins for AnyExpression

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    fe14f25 View commit details
    Browse the repository at this point in the history

  15. decoder: Implement reference targets for AnyExpression

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    5e67d86 View commit details
    Browse the repository at this point in the history

  16. decoder: Account for incomplete expressions in functionExpr args

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    0503b17 View commit details
    Browse the repository at this point in the history

  17. decoder: Fix return type comparison in functionExpr 

    go-cty's understanding of type conformity is a lot stricter than Terraform's, mostly for historical reasons.

For example, in Terraform `"42"` is convertible to `42`.
Similarly, in `number_attr = "${var.number}"` the template expression is technically a string,
and while this is *not* the preferred way to write it, it works nonetheless.
This used to be the only way to do interpolation in older Terraform versions (<0.12).

Some other products (language servers) may find the stricter comparison more helpful, but we don't have
enough real feedback/use cases to make the comparison customizable in any way. It is something we could
consider in the future though.
    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4f0a6fd View commit details
    Browse the repository at this point in the history

  18. decoder: Add partial arg test for functionExpr

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    70e9187 View commit details
    Browse the repository at this point in the history

  19. decoder: Add comment to clarify reason for condition

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    63ba8d3 View commit details
    Browse the repository at this point in the history

  20. decoder: Implement InferType() for Any

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    2fb6cc9 View commit details
    Browse the repository at this point in the history

  21. decoder: Report function names with appropriate token type

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9c744a1 View commit details
    Browse the repository at this point in the history

  22. decoder: Account for traversal trailing dot in functionExpr argument

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    2e12db4 View commit details
    Browse the repository at this point in the history

  23. decoder: Fix reporting of semantic tokens for functionExpr

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    73a54e1 View commit details
    Browse the repository at this point in the history

  24. decoder: Test semantic tokens for functions

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9f763e5 View commit details
    Browse the repository at this point in the history

  25. decoder: Extend hover tests for functions

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e7a6667 View commit details
    Browse the repository at this point in the history

  26. decoder: Remove TODOs (follow-up issues will be filed)

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b80119d View commit details
    Browse the repository at this point in the history

  27. decoder: add test for mismatching argument in semtok (Any)

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c82e3fa View commit details
    Browse the repository at this point in the history

  28. decoder: add test for mismatching argument in hover (Any)

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    5feeaa6 View commit details
    Browse the repository at this point in the history

  29. decoder: Add remaining tests for Any

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    250321c View commit details
    Browse the repository at this point in the history

  30. decoder: Add literal type hover tests for Any

    @radeksimko @dbanck
    radeksimko authored and dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    352c5e1 View commit details
    Browse the repository at this point in the history

  31. decoder: Add reference hover tests for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    fbb9361 View commit details
    Browse the repository at this point in the history

  32. decoder: Add semantic token tests for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    1266df0 View commit details
    Browse the repository at this point in the history

  33. decoder: Return early for function calls without references

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    6f40469 View commit details
    Browse the repository at this point in the history

  34. decoder: Test collection for reference targets for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4dd2044 View commit details
    Browse the repository at this point in the history

  35. decoder: Test collection for reference origins for Any

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    84d0789 View commit details
    Browse the repository at this point in the history

  36. decoder: Fix AnyExpression Map completion tests

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9ed053d View commit details
    Browse the repository at this point in the history

  37. Fix duplicate completion entries for complex types

    @dbanck
    dbanck committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f2c8ee0 View commit details
    Browse the repository at this point in the history