Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder: Reflect LiteralValue Description & IsDeprecated in completion/hover #253

Merged
merged 2 commits into from
Apr 18, 2023
Merged

decoder: Reflect LiteralValue Description & IsDeprecated in completion/hover #253

merged 2 commits into from
Apr 18, 2023

Conversation

radeksimko
Copy link
Member

As discovered in #251

LiteralValue constraint (prior to this patch) ignores Description and IsDeprecated fields during completion and hover.

Example UX Before

2023-04-13 14 08 17

Example UX After

2023-04-13 14 08 47

@radeksimko radeksimko added the bug Something isn't working label Apr 13, 2023
@radeksimko radeksimko requested a review from a team as a code owner April 13, 2023 13:09
@radeksimko radeksimko self-assigned this Apr 13, 2023
@radeksimko radeksimko mentioned this pull request Apr 13, 2023
Merged
5 tasks
dbanck
dbanck approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbanck dbanck merged commit caa410d into main Apr 18, 2023
@dbanck dbanck deleted the b-lit-value-metadata branch April 18, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@radeksimko radeksimko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radeksimko @dbanck