Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also check that the AccessTokenExpiry has not passed #181

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

lursu
Copy link
Contributor

@lursu lursu commented Apr 6, 2023

πŸ› οΈ Description

πŸ”— External Links

πŸ‘ Definition of Done

  • SDK added
  • SDK updated
  • Tests added?
  • Docs updated?

@lursu lursu requested a review from a team April 6, 2023 18:33
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! :)

Copy link
Contributor

@jesdavpet jesdavpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I didn't read the diff before approving ... ⚠️

This is just a rubber stamp approval to +1 @bcmdarroch's review until we can remove @hashicorp/experiences-platform from this repo's CODEOWNERS file.

@lursu lursu merged commit 4df81c8 into main Apr 13, 2023
@lursu lursu deleted the VAULT-14726/fix_issue_failing_to_regen_token branch April 13, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants