Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker naming fix #37

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Docker naming fix #37

merged 2 commits into from
Jul 5, 2022

Conversation

mnyrop
Copy link
Contributor

@mnyrop mnyrop commented Jul 5, 2022

Description

This is a documentation fix only. Just thought I'd share back while using this resource.

The PR updates docker resource names to reflect 11a4af3, replacing hello-vault-go prefix with sample-app for users following along with the README.

Type of change

  • Other (Documentation)

container names likely changed during directory structure reorg PR hashicorp#30
@mnyrop mnyrop requested a review from a team July 5, 2022 19:23
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 5, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@averche averche merged commit bb65be6 into hashicorp:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants