Skip to content

Commit

Permalink
Merge pull request #221 from jrasell/b_gh_220
Browse files Browse the repository at this point in the history
Do not fail a deployment when nodes have been filtered during eval.
  • Loading branch information
jrasell committed Jul 22, 2018
2 parents 2cfd453 + 021cdbe commit 54b6b77
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions levant/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,10 @@ func (l *levantDeployment) evaluationInspector(evalID *string) error {
}
}

return fmt.Errorf("evaluation %v finished with status %s but failed to place allocations",
*evalID, evalInfo.Status)
// Do not return an error here; there could well be information from
// Nomad detailing filtered nodes but the deployment will still be
// successful. GH-220.
return nil

default:
time.Sleep(1 * time.Second)
Expand Down

0 comments on commit 54b6b77

Please sign in to comment.