Skip to content

Commit

Permalink
Merge pull request #52 from jrasell/b_gh_50
Browse files Browse the repository at this point in the history
Nomad jobs of type batch do not produce evaluations.
  • Loading branch information
jrasell committed Dec 1, 2017
2 parents 81db1b2 + 2c60e65 commit c745056
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions levant/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ func (c *nomadClient) Deploy(job *nomad.Job, autoPromote int, forceCount bool) (
return
}

// GH-50: batch job types do not return an evaluation upon registration.
if eval == nil && *job.Type == nomadStructs.JobTypeBatch {
logging.Debug("levant/deploy: job type %s does not create evaluations", nomadStructs.JobTypeBatch)
return true
}

// Trigger the evaluationInspector to identify any potential errors in the
// Nomad evaluation run. As far as I can tell from testing; a single alloc
// failure in an evaluation means no allocs will be placed so we exit here.
Expand Down

0 comments on commit c745056

Please sign in to comment.