Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomad jobs of type batch do not produce evaluations. #52

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Dec 1, 2017

Previously Levant would register the job and then check the return
for the eval_ID and thus continue with the deployment checking.
Nomad batch jobs do not produce an evaluation upon registration
and therefore would cause an error within Levant which was not
handled in the most appropriate manner. This change checks the job
type and eval return to properly catch batch job registrations and
log correct information.

In the future Levant should be updated to perform a basic running
check on batch jobs to provide further deployment feedback.

Closes #50

Previously Levant would register the job and then check the return
for the eval_ID and thus continue with the deployment checking.
Nomad batch jobs do not produce an evaluation upon registration
and therefore would cause an error within Levant which was not
handled in the most appropriate manner. This change checks the job
type and eval return to properly catch batch job registrations and
log correct information.

In the future Levant should be updated to perform a basic running
check on batch jobs to provide further deployment feedback.

Closes #50
@jrasell jrasell added the bug label Dec 1, 2017
@jrasell
Copy link
Member Author

jrasell commented Dec 1, 2017

@pmcatominey tagging as you noticed this issue. I will raise a separate ticket to add basic batch job status verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants