verify job.Type isn't nil before continuing #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch will still lead to a SEGV as the dereference is to a nil pointer. First verify that job.Type isn't nil.
jrasell
requested changes
Nov 14, 2017
levant/deploy.go
Outdated
| @@ -47,6 +47,12 @@ func (c *nomadClient) Deploy(job *nomad.Job, autoPromote int) (success bool) { | |||
| return | |||
| } | |||
|
|
|||
| // If job.Type isn't set we can't continue | |||
| if job.Type == nil { | |||
| logging.Error("levant/deploy: Nomad job `type` is not set. Should be set to `service`") | |||
There was a problem hiding this comment.
pedantic I know; but could the log messaged be change slightly? In particular not set. Should to not set, should
There was a problem hiding this comment.
No problem, change is pushed!
|
Thanks for the PR @dropje86, I added a small comment about the log line but other than that it looks good. |
jrasell
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch will still lead to a SEGV as the dereference is to a nil
pointer. First verify that job.Type isn't nil.
Still the same issue as here: #31